Skip to content

feat(cdk-experimental/selection): Add unit tests #19945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2020
Merged

feat(cdk-experimental/selection): Add unit tests #19945

merged 1 commit into from
Jul 21, 2020

Conversation

yifange
Copy link
Contributor

@yifange yifange commented Jul 10, 2020

Add unit tests for CdkSelection and related components.

Issue #18581

@yifange yifange force-pushed the cdk-selection-tests branch from 0792034 to 7a762d7 Compare July 11, 2020 04:43
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 11, 2020
@yifange yifange marked this pull request as ready for review July 11, 2020 22:32
@yifange yifange requested a review from jelbourn as a code owner July 11, 2020 22:32
jelbourn
jelbourn reviewed Jul 15, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks great, just a couple minor nits

@yifange yifange force-pushed the cdk-selection-tests branch 2 times, most recently from d637d21 to ac7ac15 Compare July 16, 2020 22:23
@yifange yifange force-pushed the cdk-selection-tests branch from ac7ac15 to 6ecf810 Compare July 16, 2020 23:09
jelbourn
jelbourn approved these changes Jul 20, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jul 20, 2020
@wagnermaciel
Copy link
Contributor

@jelbourn I'm getting an error trying to submit this:

Could not merge the specified pull request.
Pull request is set to wrong base branch. Please update the PR in the Github UI to one of the following branches: master, 10.0.x.

@jelbourn jelbourn added target: development-branch and removed target: patch This PR is targeted for the next patch release labels Jul 21, 2020
@jelbourn
Copy link
Member

@wagnermaciel my bad, I set the wrong label. It should be fine now

@wagnermaciel wagnermaciel merged commit 45f7a0e into angular:cdk-selection Jul 21, 2020
yifange added a commit to yifange/components that referenced this pull request Aug 6, 2020
@yifange
CdkSelection: Add unit tests (angular#19945)
3967b15
andrewseguin pushed a commit to yifange/components that referenced this pull request Aug 13, 2020
@yifange @andrewseguin
CdkSelection: Add unit tests (angular#19945)
ee91cbe
andrewseguin pushed a commit that referenced this pull request Aug 14, 2020
@yifange
feat(cdk-experimental/selection): Merge cdk–selection to the master (#…
ebb3998 
…20229)

* feat(cdk-experimental/selection): add selection state to a list of items  (#18424)

* feat(material-experimental/selection): add mat APIs for cdk-experimental/selection (#18620)

* CdkSelection: Add unit tests (#19945)

* feat(cdk-experiment/selection): Merge to master
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yifange @wagnermaciel @jelbourn @googlebot